Upgrade HA network configuration #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as51340
force-pushed
the
update-ha-network-configuration
branch
from
7570f32 to
15a6fa8
Compare
antejavor
reviewed
Nov 27, 2024
| @@ -13,6 +13,7 @@ spec: | |||
| metadata: | |||
| labels: | |||
| app: memgraph-data-{{ $data.id }} | |||
| instance-type: data | |||
There was a problem hiding this comment.
Do you use this anywhere?
antejavor
approved these changes
Nov 27, 2024
as51340
added a commit
that referenced
this pull request
Dec 2, 2024
Update HA network configuration --------- Co-authored-by: Ante Javor <ante.javor@memgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bolt port, replication port, management port and coordinator port are always the same for all instances, hence I abstracted them in values.yaml. Coordinators need only one service for external access. User has an option of using NodePort, which is advised to be used when deploying locally, and of using LoadBalancer which is advised to be used on cloud deployments.