Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read of data from elastic in later versions. #505

Conversation

nagi49000
Copy link
Contributor

Description

Update elastic_search_serialization.py only move around ID under _SOURCE if it ID exists. Tested on 8.14.3.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

#503

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

Copy link

sonarcloud bot commented Aug 13, 2024

@gitbuda
Copy link
Member

gitbuda commented Aug 13, 2024

I've approved the CI run, waiting for the run to finish, but from my perspective this can be merged 💪 @nagi49000 thank you 🙏

@gitbuda
Copy link
Member

gitbuda commented Aug 13, 2024

The run failed because an external contributor runs don't have access to the secretes -> the changes seems 100% fine -> merging.

@gitbuda gitbuda merged commit 052bf37 into memgraph:main Aug 13, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Elasticsearch synchronization is not always able to read in data from elastic
2 participants