Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leiden algorithm #508

Merged
merged 65 commits into from
Oct 14, 2024
Merged

Add Leiden algorithm #508

merged 65 commits into from
Oct 14, 2024

Conversation

DavIvek
Copy link
Contributor

@DavIvek DavIvek commented Sep 5, 2024

Description

Please briefly explain the changes you made here.

Pull request type

  • Algorithm/Module

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Added the Leiden community detection algorithm.
  • Link the documentation PR here
  • Tag someone from docs team in the comments
    @hal-eisen-MG

TODOs

  • Basic version with the “leaf” communities
  • Finish the basic implementation → return intermediate communities

closes #506

@DavIvek DavIvek added the Docs needed Docs needed label Sep 5, 2024
@DavIvek DavIvek self-assigned this Sep 5, 2024
Copy link

New page

@gitbuda gitbuda changed the title Add Leiden algorithm [COM-1] Add Leiden algorithm Sep 23, 2024
@DavIvek DavIvek modified the milestones: 1.14.0, 1.21.0 Oct 10, 2024
@DavIvek DavIvek requested a review from gitbuda October 12, 2024 00:25
@DavIvek DavIvek marked this pull request as ready for review October 12, 2024 00:33
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much much better state 💪 Two more things and then it's ready to be merged:

  • consistent pragma once usage
  • I think we still don't have the automated formatting (under the whole mage repo), I've created a new issue for that (Automate formatting under the whole mage repo #519), for now just apply clang-format -i {{all_cpp_and_hpp_files}} (use the clang-format 17 from the toolchain-v5)

@gitbuda gitbuda added the enhancement enhancement label Oct 12, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@gitbuda gitbuda merged commit c32d112 into main Oct 14, 2024
5 of 6 checks passed
@gitbuda gitbuda deleted the add-leiden-algorithm branch October 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed enhancement enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Leiden community detection algorithm
2 participants