-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts to build all package manually #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an option is to add empty.txt to .gitignore, I would do that. Other things look good to me
There are still comments leftover here: https://github.com/memgraph/docker-image-shipping/pull/1 |
I am not sure why we even have these files? If we can add them to gitignore, we can also delete them? @as51340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, just change the branch name to airtable task like we do in the rest of the repositories (T...-FL-...)
Yes I am also not sure but I think noting bad will happen if we delete them. Delete them and it is approve from me |
@Josipmrden unfortunately, to rename a remote branch I need to create a new one and delete this one, which includes making a new PR. Let me know if that is what you want me to do. Meanwhile I renamed the PR to match our format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that my suggestions in the initial PR were accepted; everything looks good to me now!
Added some cleaning to the scripts and how the images are generated. I hope it will result in a much faster build and less commands to generate custom images. We still need to figure out how to decrease MAGE build time since it seems it's taking 4 hours. |
Re-requesting review again, on my changes @as51340 @antepusic @antoniofilipovic @brunos252 |
In case, a custom combination of versions needs to be created.
TODOs
RelWithDebInfo
pack_
scriptsbuild_memgraph.sh
image_name
under allpack_
scriptspack_
scriptsoperating_system
function work on Mac -> HOW?