Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to build all package manually #39

Merged
merged 30 commits into from
Jul 23, 2023
Merged

Conversation

brunos252
Copy link
Contributor

@brunos252 brunos252 commented Feb 15, 2023

In case, a custom combination of versions needs to be created.

TODOs

  • Make default build mode for Memgraph RelWithDebInfo
  • Enable building ARM deb package because of M1
  • Add cleanup options to all pack_ scripts
  • Add sudo vs non-sudo option to the build_memgraph.sh
  • Parametrize image_name under all pack_ scripts
  • Deduce the latest available package or parametrize the exact package inside pack_ scripts
  • Make the operating_system function work on Mac -> HOW?

@brunos252 brunos252 self-assigned this Feb 15, 2023
Copy link

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an option is to add empty.txt to .gitignore, I would do that. Other things look good to me

@brunos252
Copy link
Contributor Author

There are still comments leftover here: https://github.com/memgraph/docker-image-shipping/pull/1
Which I didn't currently have time to address

@brunos252
Copy link
Contributor Author

brunos252 commented Feb 15, 2023

If an option is to add empty.txt to .gitignore, I would do that. Other things look good to me

I am not sure why we even have these files? If we can add them to gitignore, we can also delete them? @as51340

@brunos252 brunos252 requested a review from as51340 February 15, 2023 15:35
Copy link

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, just change the branch name to airtable task like we do in the rest of the repositories (T...-FL-...)

docker-image-build/memgraph_deb/build.sh Outdated Show resolved Hide resolved
@as51340
Copy link

as51340 commented Feb 15, 2023

If an option is to add empty.txt to .gitignore, I would do that. Other things look good to me

I am not sure why we even have these files? If we can add them to gitignore, we can also delete them? @as51340

Yes I am also not sure but I think noting bad will happen if we delete them. Delete them and it is approve from me

@brunos252
Copy link
Contributor Author

Seems okay, just change the branch name to airtable task like we do in the rest of the repositories (T...-FL-...)

@Josipmrden unfortunately, to rename a remote branch I need to create a new one and delete this one, which includes making a new PR. Let me know if that is what you want me to do. Meanwhile I renamed the PR to match our format.

@brunos252 brunos252 changed the title Add docker-image-shipping repo [main < T596-FL] Add docker-image-shipping repo Feb 16, 2023
@brunos252 brunos252 requested a review from Josipmrden February 16, 2023 11:53
Copy link

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that my suggestions in the initial PR were accepted; everything looks good to me now!

@antepusic antepusic added enhancement enhancement and removed enhancement enhancement labels Feb 17, 2023
@Josipmrden
Copy link

Added some cleaning to the scripts and how the images are generated. I hope it will result in a much faster build and less commands to generate custom images.

We still need to figure out how to decrease MAGE build time since it seems it's taking 4 hours.

@Josipmrden Josipmrden requested review from antepusic and as51340 March 5, 2023 22:10
@Josipmrden
Copy link

Re-requesting review again, on my changes @as51340 @antepusic @antoniofilipovic @brunos252

@gitbuda gitbuda changed the title [main < T596-FL] Add docker-image-shipping repo Add scripts to build all package manually Jun 24, 2023
@gitbuda gitbuda merged commit 875d934 into main Jul 23, 2023
@gitbuda gitbuda deleted the add-docker-build-scripts branch July 23, 2023 13:29
@gitbuda gitbuda mentioned this pull request Jul 23, 2023
2 tasks
@MarkoBarisic MarkoBarisic mentioned this pull request Nov 17, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants