Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auth with custom schemes #62

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
Clarify comment
  • Loading branch information
antepusic committed Jun 18, 2024
commit adeaa28ca715d3303655c48e78b37b2e5f4f4acc
6 changes: 3 additions & 3 deletions src/mgclient.c
Original file line number Diff line number Diff line change
@@ -385,9 +385,9 @@ static mg_map *build_hello_extra(const char *user_agent, const char *scheme,
}
}

// The "basic" scheme requires a username and a password in the HELLO message.
// Other schemes (save for "kerberos", which is not supported by Memgraph) do
// not have such requirements:
// The "basic" scheme requires a username and a password/credential within the
// HELLO message. Other schemes (save for "kerberos", which is not supported
// by Memgraph) do not have such requirements:
// https://neo4j.com/docs/bolt/current/bolt/message/#messages-hello
// https://neo4j.com/docs/bolt/current/bolt/message/#messages-logon
if (scheme && strcmp(scheme, "basic") == 0) {
Loading