Fix: Fix physics behavior #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h container children
…ator-and-fix-cleanup
tonilastre
approved these changes
Oct 10, 2022
| @@ -207,12 +207,14 @@ export class D3SimulatorEngine extends Emitter<D3SimulatorEvents> { | |||
|
|
|||
| this.initSimulation(settings); | |||
| this.emit(D3SimulatorEngineEventType.SETTINGS_UPDATED, { settings: this.settings }); | |||
|
|
|||
| this.runStabilization(); | |||
There was a problem hiding this comment.
To respond to your comment. I think this is fine, if we see in the future that this is not what the user expects, then we can figure out how to overcome that.
Base automatically changed from
apply-emitter-in-simulator-and-fix-cleanup
to
release/0.1.2
October 10, 2022 11:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simulator-scenarios.htmlUpdating the simulation settings now runs stabilization. @tonilastre not sure if this is expected. It was useful in my case when using the library in our projects.