-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Added support for double click events #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, please run the npm run lint
(and npm run lint:fix
) to fix lint issues. I've added automatic lint in the baseline branch that will be used for your PR: #51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix. There is one issue left around the consistency of events, so please check it out!
Co-authored-by: Toni <tonilastre@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Please run npm run lint:fix
once more and commit, there are 2 standing issues. Btw, from the next version forward, linting will be in the pre-commit hook.
This PR will add support for double click events, the library exposes the 3 new events
For example, to handle NODE_DOUBLE_CLICK event we can use