-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #65
Merged
Merged
Spelling #65
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
418b499
spelling: arbitrary
jsoref 637ac0e
spelling: bezier
jsoref d88d73c
spelling: emitter
jsoref 71714c1
spelling: inspired
jsoref 538a566
spelling: javascript
jsoref 863b21a
spelling: lighter
jsoref 0d5bdcc
spelling: the
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ export const getCurvedArrowShape = <N extends INodeBase, E extends IEdgeBase>(ed | |
|
||
const controlPoint = edge.getCurvedControlPoint(); | ||
const arrowPoint = findBorderPoint(edge, target); | ||
const guidePos = getPointBrezier(edge, Math.max(0.0, Math.min(1.0, arrowPoint.t + guideOffset)), controlPoint); | ||
const guidePos = getPointBezier(edge, Math.max(0.0, Math.min(1.0, arrowPoint.t + guideOffset)), controlPoint); | ||
const angle = Math.atan2(arrowPoint.y - guidePos.y, arrowPoint.x - guidePos.x); | ||
|
||
const length = 1.5 * scaleFactor + 3 * lineWidth; // 3* lineWidth is the width of the edge. | ||
|
@@ -55,10 +55,10 @@ export const getCurvedArrowShape = <N extends INodeBase, E extends IEdgeBase>(ed | |
* | ||
* @param {EdgeCurved} edge Edge | ||
* @param {number} percentage Percentage of the line to get position from | ||
* @param {IPosition} viaNode Brezier node on the curved line | ||
* @param {IPosition} viaNode Bezier node on the curved line | ||
* @return {IPosition} Position on the line | ||
*/ | ||
const getPointBrezier = <N extends INodeBase, E extends IEdgeBase>( | ||
const getPointBezier = <N extends INodeBase, E extends IEdgeBase>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm hoping I'm right... |
||
edge: EdgeCurved<N, E>, | ||
percentage: number, | ||
viaNode: IPosition, | ||
|
@@ -111,7 +111,7 @@ const findBorderPoint = <N extends INodeBase, E extends IEdgeBase>( | |
while (low <= high && iteration < maxIterations) { | ||
middle = (low + high) * 0.5; | ||
|
||
pos = { ...getPointBrezier(edge, middle, viaNode), t: 0 }; | ||
pos = { ...getPointBezier(edge, middle, viaNode), t: 0 }; | ||
// angle = Math.atan2(nodePoints.y - pos.y, nodePoints.x - pos.x); | ||
// distanceToBorder = node.getDistanceToBorder(angle); | ||
distanceToBorder = node.getDistanceToBorder(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brand