Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auth with custom schemes #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antepusic
Copy link

@antepusic antepusic commented May 20, 2024

This PR adds the scheme parameter to the connect function.
Memgraph’s SSO capabilities use custom values of scheme, making this PR necessary for SSO via Python client.

@antepusic antepusic added feature feature Docs - changelog only Docs - changelog only labels May 20, 2024
@antepusic antepusic self-assigned this May 20, 2024
@antepusic antepusic added Docs needed Docs needed and removed Docs - changelog only Docs - changelog only labels May 23, 2024
@antepusic antepusic marked this pull request as ready for review June 18, 2024 22:56
@antepusic antepusic requested a review from andrejtonev June 20, 2024 10:24
Copy link

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but shouldn't we also add the sso certificate to the parameter list?

@antepusic
Copy link
Author

@andrejtonev The certificate is not a part of the relevant Bolt messages; the path to the certificate is an environment variable instead (e.g. MEMGRAPH_SSO_ENTRA_ID_SAML_SP_CERT in memgraph#2049)

@antepusic antepusic requested a review from andrejtonev June 21, 2024 15:04
@antepusic antepusic changed the title Add support for auth with custom schemas Add support for auth with custom schemes Jun 26, 2024
@gitbuda gitbuda mentioned this pull request Aug 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants