Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a --with-freetype option instead of having to uncomment #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lehoff
Copy link

@lehoff lehoff commented May 18, 2018

In premake4.lua there was a comment about what to uncomment when needing FreeType support.
This has now been turned into a premake option that can be passed in as a command line option like this:

$ premake4 --with-freetype gmake

In premake4.lua there was a comment about what to uncomment when needing FreeType support.
This has now been turned into a premake option that can be passed in as a command line option like this:
$ premake4 --with-freetype gmake
@cdegroot
Copy link

By the way, the reason for me for having to use Freetype is that when I tried NanoVG with the STB Truetype library on a RaspberryPi using VideoCore, strange things happened. The errors that came back indicated a failure to allocate memory, but looking at malloc traces that is unlikely, so it seems that in this particular configuration, the STB code writes in a wrong place. Freetype works fine (and I guess should render somewhat nicer, even if it enlarges the footprint of NanoVG a bit?). Currently I just forked NanoVG with a patched premake4.lue but having a command line option would be nicer.

So consider this my: yes, please, accept this PR ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants