mod msac: Document range of values used and returned and mask return values
#1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/mod-recon-u8s
branch
2 times, most recently
from
61d6354 to
37cd90c
Compare
kkysen
force-pushed
the
kkysen/struct-SegmentId
branch
from
527d779 to
c4cb161
Compare
randomPoison
approved these changes
Jun 20, 2024
kkysen
force-pushed
the
kkysen/struct-SegmentId
branch
from
c4cb161 to
e2542e2
Compare
kkysen
force-pushed
the
kkysen/mod-recon-u8s
branch
from
37cd90c to
4fbda0f
Compare
These are checked with `debug_assert!`s and forced in-bounds with `&`. This tells the compiler the bounds of the return values, so it can better optimize (e.x. elide bounds checks).
kkysen
force-pushed
the
kkysen/struct-SegmentId
branch
from
e2542e2 to
969a859
Compare
kkysen
force-pushed
the
kkysen/mod-recon-u8s
branch
from
4fbda0f to
37a2947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn decode_coefsis slow #1180.This adds docs to the
mod msacfns on the range of their args and return values, and for return values, it ensures this by masking them. This eliminates a bunch of bounds checks in callers, likefn decode_coefs.I also included a couple of other small commits in here; didn't really want to put them all in their own PRs.