Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum Rav1dFilterMode: Use instead of u8s or Dav1dFilterMode in more places #1234

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Jun 20, 2024

This removes a bunch of casts and also moves checks to where the Rav1dFilterModes are first calculated, and where it is deducible that no checks are needed.

@kkysen kkysen requested review from randomPoison and fbossen June 20, 2024 03:17
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from c239d58 to 1b6eaa6 Compare June 20, 2024 03:18
@kkysen kkysen force-pushed the kkysen/mod-recon-u8s branch from 596e3ea to 61d6354 Compare June 20, 2024 03:24
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch 2 times, most recently from 43b1a32 to aa644cd Compare June 20, 2024 05:40
@kkysen kkysen force-pushed the kkysen/mod-recon-u8s branch from 61d6354 to 37cd90c Compare June 20, 2024 05:40
@kkysen kkysen force-pushed the kkysen/mod-recon-u8s branch from 37cd90c to 4fbda0f Compare June 21, 2024 21:13
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from aa644cd to 303956e Compare June 21, 2024 21:13
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from 303956e to be56aff Compare June 23, 2024 23:58
@kkysen kkysen force-pushed the kkysen/mod-recon-u8s branch from 4fbda0f to 37a2947 Compare June 23, 2024 23:58
Base automatically changed from kkysen/mod-recon-u8s to main June 24, 2024 00:10
@kkysen kkysen merged commit 13478e1 into main Jun 24, 2024
@kkysen kkysen deleted the kkysen/enum-Rav1dFilterMode-use-everywhere branch June 24, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants