Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn get_skip_ctx: Optimize #1235

Merged
merged 7 commits into from
Jun 24, 2024
Merged

fn get_skip_ctx: Optimize #1235

merged 7 commits into from
Jun 24, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Jun 20, 2024

Optimize and remove all of the bounds checks by checking dir.len() directly instead of tx.

@kkysen kkysen requested review from randomPoison and fbossen June 20, 2024 03:26
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from 43b1a32 to aa644cd Compare June 20, 2024 05:40
@kkysen kkysen force-pushed the kkysen/fn-get_skip_ctx-optimize branch from 170a19c to 92583a9 Compare June 20, 2024 05:40
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, have you profiled this to verify that it's having a positive performance impact?

@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from aa644cd to 303956e Compare June 21, 2024 21:13
@kkysen kkysen force-pushed the kkysen/fn-get_skip_ctx-optimize branch from 92583a9 to 3fc67ba Compare June 21, 2024 21:13
@kkysen kkysen force-pushed the kkysen/enum-Rav1dFilterMode-use-everywhere branch from 303956e to be56aff Compare June 23, 2024 23:58
@kkysen kkysen force-pushed the kkysen/fn-get_skip_ctx-optimize branch from 3fc67ba to 75be684 Compare June 23, 2024 23:58
Base automatically changed from kkysen/enum-Rav1dFilterMode-use-everywhere to main June 24, 2024 00:11
@kkysen kkysen merged commit da472a5 into main Jun 24, 2024
26 checks passed
@kkysen kkysen deleted the kkysen/fn-get_skip_ctx-optimize branch June 24, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants