enum TileStateRef: Manual impl Atom instead of #[derive(Atom)]ing it, since the derive may panic
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomPoison
approved these changes
Jun 25, 2024
fbossen
approved these changes
Jun 27, 2024
kkysen
force-pushed
the
kkysen/enum-CfSelect-optimize
branch
from
a7c736a to
7065142
Compare
kkysen
force-pushed
the
kkysen/enum-TileStateRef-manual-impl-Atom
branch
2 times, most recently
from
e16709e to
029f56e
Compare
kkysen
force-pushed
the
kkysen/enum-CfSelect-optimize
branch
from
7065142 to
6155d6b
Compare
…ng it, since the derive may panic. It is more optimal to `.unwrap_or_default()`, which is a `cmov`, rather than branching to a panic message, which bloats the code a lot. This reduces stack usage in `fn decode_coefs` by 64 bytes, from 296 to 232.
kkysen
force-pushed
the
kkysen/enum-CfSelect-optimize
branch
from
6155d6b to
810942f
Compare
kkysen
force-pushed
the
kkysen/enum-TileStateRef-manual-impl-Atom
branch
from
029f56e to
951d69d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn decode_coefsis slow #1180.It is more optimal to
.unwrap_or_default(), which is acmov, rather than branching to a panic message, which bloats the code a lot.This reduces stack usage in
fn decode_coefsby 64 bytes, from 296 to 232.