enum CfSelect: Optimize some checks and make offsets u32s
#1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
reviewed
Jun 30, 2024
kkysen
force-pushed
the
kkysen/enum-CfSelect-optimize
branch
2 times, most recently
from
7065142 to
6155d6b
Compare
…ros for specific types.
…which don't overflow when multiplied as `usize`s on 64-bit.
This removes the bounds check for `CfSelect::Task`, but not yet for `CfSelect::Frame`, but allows it to be pre-computed.
kkysen
force-pushed
the
kkysen/enum-CfSelect-optimize
branch
from
6155d6b to
810942f
Compare
rinon
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn decode_coefsis slow #1180.I forgot to open this PR earlier. This optimizes some
CfSelectuses and makes its offset, as well as the offsets inRav1dTileState_frame_threadu32s instead ofusizes, saving space, prohibiting overflows on multiplications, and reducing stack usage a bit.