Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

struct StableRef: Refactor out from CArc::{,base_}stable_ref and unsafe impl Send + Sync on it #1278

Merged
merged 0 commits into from
Jul 3, 2024
Merged

struct StableRef: Refactor out from CArc::{,base_}stable_ref and unsafe impl Send + Sync on it #1278

merged 0 commits into from
Jul 3, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Jul 1, 2024

This helps make CArc<T: Send + Sync>: Send + Sync (still need to fix CBox in the next PR).

@kkysen kkysen requested review from rinon and randomPoison July 1, 2024 18:44
@kkysen kkysen force-pushed the kkysen/struct-ITUTT35PayloadPtr-unsafe-impl-Send-Sync branch from 1447aac to 6c16a96 Compare July 1, 2024 21:35
@kkysen kkysen force-pushed the kkysen/struct-StableRef-unsafe-impl-Send-Sync branch from e6f473f to 1164d69 Compare July 1, 2024 21:35
rinon
rinon requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@rinon rinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you just impl Send+Sync for CArc if T implements them?

kkysen
kkysen commented Jul 2, 2024
View reviewed changes
rinon
rinon reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@rinon rinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked offline about this, it's ok, just a few small doc comments now.

@kkysen kkysen force-pushed the kkysen/struct-StableRef-unsafe-impl-Send-Sync branch from 1164d69 to 552b028 Compare July 3, 2024 06:14
@kkysen kkysen merged commit 552b028 into kkysen/struct-ITUTT35PayloadPtr-unsafe-impl-Send-Sync Jul 3, 2024
5 checks passed
@kkysen kkysen force-pushed the kkysen/struct-ITUTT35PayloadPtr-unsafe-impl-Send-Sync branch from 6c16a96 to 8de9a7c Compare July 3, 2024 06:14
@kkysen kkysen mentioned this pull request Jul 3, 2024
Merged
kkysen added a commit that referenced this pull request Jul 10, 2024
@kkysen
struct StableRef: Refactor out from CArc::{,base_}stable_ref and …
b80ead5 
…`unsafe impl Send + Sync` on it (#1282)

* Part of #1177.

This makes `CArc<T: Send + Sync>: Send + Sync`.

Accidentally "merged" #1278 (it says merged but I didn't merge it) when
I flipped the order of the branches and PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinon rinon rinon requested changes

@randomPoison randomPoison randomPoison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkysen @rinon @randomPoison