Fix unused compiler warnings #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
approved these changes
May 5, 2023
There was a problem hiding this comment.
The changes LGTM, but I'm not sure it fully resolves #13 since that also includes updating CI to deny warnings.
I also changed the PR title since I think "silence" implies just turning the warnings off (allowing them), but this properly fixes the remaining ones, which seem to be all from unused items.
|
That's fine, that makes sense. I was just looking at what #13 said. I agree it's not super important, though. This PR looks good then with it's current description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13