Ci cross compile #141
Merged
Ci cross compile #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
ci-cross-compile
branch
4 times, most recently
from
ffbae7c
to
7c981df
Compare
…st?); it often takes over 1 minute to 'post rust cache', building our dependencies is much, much faster than that
folkertdev
force-pushed
the
ci-cross-compile
branch
from
5429be0
to
1d624db
Compare
folkertdev
commented
Aug 12, 2024
Comment on lines
-82
to
-85
| - name: Rust cache | ||
| uses: Swatinem/rust-cache@3cf7f8cc28d1b4e7d01e3783be10a97d55d483c8 | ||
| with: | ||
| shared-key: "${{matrix.rust}}-${{matrix.target}}" |
There was a problem hiding this comment.
this just took more time than it saved
Comment on lines
-124
to
+120
| packages: qemu qemu-user qemu-user-static qemu-system-s390x gcc-s390x-linux-gnu gcc-i686-linux-gnu | ||
| packages: qemu-user qemu-user-static qemu-system-s390x gcc-s390x-linux-gnu gcc-i686-linux-gnu g++-s390x-linux-gnu |
There was a problem hiding this comment.
cmake needs the g++ compiler apparently. or it wants it anyway. fine
| libz-sys = { version = "1.1.12", default-features = false, features = ["zlib-ng"] } # use libz-ng in libz compat mode | ||
| libz-sys = { version = "1.1.19", default-features = false, features = ["zlib-ng"] } # use libz-ng in libz compat mode |
There was a problem hiding this comment.
this release fixes a bug with a missing file that caused issues for the s390x target rust-lang/libz-sys#205
| let mut input = [0x63, 0x00]; | ||
| let mut input = [0x63u8, 0x00]; |
There was a problem hiding this comment.
was inferred as i32 which will fail on big endian systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.