fix oversight in one of the quick deflate macros #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Aug 29, 2024
Comment on lines
-38
to
+28
| return match last { | ||
| return match $last { |
There was a problem hiding this comment.
this was the actual issue, $last was captured instead of the macro argument being used. I've moved the macros above the definition of last now so that this cannot happen by accident again.
folkertdev
force-pushed
the
fix-issue-169
branch
5 times, most recently
from
9364a6b
to
f8992fc
Compare
folkertdev
force-pushed
the
fix-issue-169
branch
from
f8992fc
to
4122e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #169