Markdown block shortcuts #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am pretty I wrote more test than that, you probably can import them. I am also pretty sure what you posted in the gist was broken (that was my understanding back then). future will tell :) |
|
I just added the position diff fix and tested the whole thing locally, worked as expected. Let me know if you find any issues with it. |
|
seems fine. pushed the tests that didn't seem to overlap with yours. Only one very specific (and strange one) is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgestes I couldn't find your version in your PR (#546) for some reason, so there was no commits to cherry-pick which would be authored by you.
This implementation is basically the same as in the Gist I shared a while back, just adds some tests and docs.
Does not include the cursor position fix for Zefyr (will be submitted separately).