Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to wrap the logger #37

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add functions to wrap the logger #37

merged 2 commits into from
Mar 27, 2024

Conversation

muir
Copy link
Collaborator

@muir muir commented Mar 27, 2024

This adds a couple of functions that can be used to override the logger in a test.

@muir muir requested a review from miccagiann March 27, 2024 17:24
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (2407dd0) to head (7dfd6c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   79.48%   82.41%   +2.93%     
==========================================
  Files           3        4       +1     
  Lines          78       91      +13     
==========================================
+ Hits           62       75      +13     
  Misses         10       10              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mgiannakopoulos mgiannakopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Ship IT!

@muir muir merged commit 3679620 into main Mar 27, 2024
35 checks passed
@muir muir deleted the wrapLogger branch March 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants