Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update self-hosted Kubernetes deployments examples for compatibility and consistency #1177

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

tetuyoko
Copy link
Contributor

This PR updates the Kubernetes deployment configurations (api.yaml, worker.yaml, playwright-service.yaml, configmap.yaml, and README.md) to address compatibility issues and improve consistency with the current Firecrawl application.

Key changes include:

  • Apple Silicon Compatibility: Added the --platform linux/amd64 flag to the Docker build commands to ensure compatibility when building on Apple Silicon Macs. This fixes potential runtime issues due to architecture mismatches.
  • Missing Environment Variables: Added the FLY_PROCESS_GROUP environment variable to api.yaml and worker.yaml for proper process group identification in Fly.io.
  • Corrected Playwright URL: Fixed the PLAYWRIGHT_MICROSERVICE_URL in configmap.yaml to point to the correct service endpoint, resolving communication issues with the Playwright microservice.
  • Secret Reference: Added a reference to the firecrawl-secret Secret in the worker deployment to ensure the required OPENAI_API_KEY is available before the worker starts.

These updates ensure the Kubernetes deployments are correctly configured and function as expected in various environments.

Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mogery mogery merged commit 5ac6eb7 into mendableai:main Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants