Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrapeURL/sb): enforce timeout (FIR-980) #1183

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

mogery
Copy link
Member

@mogery mogery commented Feb 14, 2025

We had a few jobs get stuck running forever on SB. Added code to enforce the timeout

@mogery mogery requested a review from nickscamara February 14, 2025 08:01
@mogery mogery changed the title fix(scrapeURL/sb): enforce timeout fix(scrapeURL/sb): enforce timeout (FIR-980) Feb 14, 2025
Copy link
Member

@nickscamara nickscamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please remove the flake files

@mogery mogery merged commit 1491b5b into main Feb 16, 2025
1 check passed
@mogery mogery deleted the mog/enforce-scrapingbee-timeout branch February 16, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants