fix(v1/types): fix extract -> json rename (FIR-1072) #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogery
force-pushed
the
mog/fix-extract-json-schema
branch
from
2fd6d88 to
308972a
Compare
|
WOW it's actually broken and not the test's fault. @nickscamara never would've noticed this without the snips system. it works! (this change broke sitemap scraping of all things!) |
mogery
force-pushed
the
mog/fix-extract-json-schema
branch
from
3ecef0a to
308972a
Compare
|
ok fixed |
nickscamara
approved these changes
Feb 18, 2025
|
Good catch!! |
nickscamara
added a commit
that referenced
this pull request
Feb 18, 2025
This reverts commit 586a10f.
nickscamara
added a commit
that referenced
this pull request
Feb 18, 2025
This reverts commit 586a10f.
nickscamara
pushed a commit
that referenced
this pull request
Feb 19, 2025
* Revert "Revert "fix(v1/types): fix extract -> json rename (FIR-1072) (#1195)"" This reverts commit e28a444. * fix(v1/types): fix bad transform * feat(v1): proxy option / stealthProxy flag (FIR-1050) (#1196) * feat(v1): proxy option / stealthProxy flag * feat(js-sdk): add proxy option * fix * fix extract tests
nickscamara
added a commit
that referenced
this pull request
Feb 19, 2025
* Nick: * Revert "fix(v1/types): fix extract -> json rename (FIR-1072) (#1195)" This reverts commit 586a10f. * Update deep-research-service.ts * Nick: * Nick: * Nick: * Nick: * Nick: * Nick: * Update deep-research-service.ts * Nick: * Update deep-research-service.ts * Apply suggestions from code review --------- Co-authored-by: Gergő Móricz <mo.geryy@gmail.com>
nickscamara
added a commit
that referenced
this pull request
Feb 19, 2025
* Nick: * Revert "fix(v1/types): fix extract -> json rename (FIR-1072) (#1195)" This reverts commit 586a10f. * Update deep-research-service.ts * Nick: * init * part 2 * Update generate-llmstxt-service.ts * Fix queue * Update queue-worker.ts * Almost there * Final touches * Update requests.http * final touches * Update requests.http * Improve logging * Change endpoint to /llmstxt * Update queue-worker.ts * Update generate-llmstxt-service.ts * Nick: cache * Update index.ts * Update firecrawl.py * Update package.json --------- Co-authored-by: Nicolas <nicolascamara29@gmail.com> Co-authored-by: Gergő Móricz <mo.geryy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091 as well as some other complaints.