Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE review for the onboarding process (get started guide) #2348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

estape11
Copy link
Contributor

@estape11 estape11 commented Apr 3, 2024

Ticket: None
Changelog: None

External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

  • Make sure that all commits follow the conventional commit specification for the Mender project.

The majority of our contributions are fixes, which means your commit should have
the form below:

fix: <SHORT DESCRIPTION OF FIX>

<OPTIONAL LONGER DESCRIPTION>

Changelog: <USER-FRIENDLY-CHANGE-DESCRIPTION> or <None>
Ticket: <TICKET NUMBER> or <None>
  • Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description

Please describe your pull request.

Thank you!

Ticket: None
Changelog: None

Signed-off-by: Esteban Agüero Pérez <esteban.aguero@northern.tech>
…t snapshot

Ticket: None
Changelog: None

Signed-off-by: Esteban Agüero Pérez <esteban.aguero@northern.tech>
Comment on lines +22 to +24
! Currently `mender-artifact snapshot` funtionality does not work with Mender Client 4.0
! as the `mender` util was splitted in multiple components, see
! [Mender snapshot](../../06.Artifact-creation/02.Create-an-Artifact-with-system-snapshot/docs.md) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estape11 As long as you have a recent enough mender-artifact it should work just fine. We changed the tool to first probe the device if mender-snapshot standalone exists, and if not fallback to mender legacy client.

Can you please double check which version of mender-artifact were you using at the time of testing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lluiscampos I was using mender-artifact version 3.11.2, the one that the instructions guides to download (https://docs.mender.io/get-started/deploy-an-operating-system-update#step-1-download-the-mender-artifact-utility-on-your-workstation)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce.

But this is a bug and needs to be fixed (not just documented). Please create a JIRA task with the steps to reproduce and we'll look at it ASAP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants