Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs.md #2422

Open
wants to merge 1 commit into
base: hosted
Choose a base branch
from
Open

Conversation

MarkGaskin
Copy link

@MarkGaskin MarkGaskin commented Jul 20, 2024

External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

  • Make sure that all commits follow the conventional commit specification for the Mender project.

The majority of our contributions are fixes, which means your commit should have
the form below:

fix: Quick typo fix

Changelog: <None>
Ticket: <None>
  • Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description

Please describe your pull request.

Thank you!

@TheYoctoJester
Copy link
Contributor

Hi @MarkGaskin, thanks a lot for the PR. It might sound a bit strange, but the patch cannot be merged until it is signed off by you, and follows the conventional commit style. The latter is already outlined in the PR description template, and the former can be done by amending the original commit (which you need for changing the description anyways):
git commit --amend -s, and then you can force-push with git push -f. At that point, the merge should be good to go.

Greetz,
Josef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants