Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add license check for third-party services #398

Merged
merged 1 commit into from
Feb 7, 2025
Merged

ci: Add license check for third-party services #398

merged 1 commit into from
Feb 7, 2025

Conversation

alfrunes
Copy link
Contributor

No description provided.

@alfrunes
ci: Add license check for third-party services
67c6a1c 
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
@alfrunes alfrunes requested a review from kjaskiewiczz January 31, 2025 10:44
kjaskiewiczz
kjaskiewiczz reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kjaskiewiczz kjaskiewiczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that the hack for license not being present in the parent directory is now covered by check with unknown in disallowed types?

@alfrunes
Copy link
Contributor Author

alfrunes commented Feb 5, 2025

Do I understand correctly that the hack for license not being present in the parent directory is now covered by check with unknown in disallowed types?

No, the hack no longer applies because of the ignore argument.

@alfrunes alfrunes requested a review from kjaskiewiczz February 5, 2025 12:40
kjaskiewiczz
kjaskiewiczz approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@kjaskiewiczz kjaskiewiczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@alfrunes alfrunes merged commit eee0656 into mendersoftware:main Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjaskiewiczz kjaskiewiczz kjaskiewiczz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfrunes @kjaskiewiczz