Support loading multiple jqueries #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, the problem here is that jquery is a library that uses define (AMD style), but passes it an explicit string which is non unique, "jquery". This means that if you load different jquery versions they will all try to define themselves as "jquery". Using the unminified jquery version (we bundle when creating MDAs anyway) and removing the jquery identifier solves this problem, as the define will then define itself as the path to the file.
This was referenced Jun 16, 2015
johanflint
added a commit
that referenced
this pull request
Jun 22, 2015
Support loading multiple JQuery versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the problem here is that jquery is a library that uses define (AMD
style), but passes it an explicit string which is non unique, "jquery".
This means that if you load different jquery versions they will all
try to define themselves as "jquery".
Using the unminified jquery version (we bundle when creating MDAs anyway)
and removing the jquery identifier solves this problem, as the define
will then define itself as the path to the file.