Skip to content

[WC-3031][WC-3034]fix: rich text table format and list style type #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

[WC-3031][WC-3034]fix: rich text table format and list style type #1775

merged 3 commits into from
Jul 29, 2025

Conversation

gjulivan
Copy link
Collaborator

@gjulivan gjulivan commented Jul 16, 2025 •
edited
Loading

Pull request type

Bug fix (non-breaking change which fixes an issue)
fix:

  • table format throws error if rich text widget placed inside table structure. this is caused by .closest(".table") function from table-better faulty logic.
  • list-style-type incorrectly parsed from/to html due to custom list format. fixed by overriding clipboard matcher and convert list html

Description

@gjulivan gjulivan requested a review from a team as a code owner July 16, 2025 07:34
@gjulivan gjulivan changed the title [WC-3031]fix: rich text table format throws error if inside another table [WC-3031][WC-3034]fix: rich text table format and list style type Jul 16, 2025
samuelreichert
samuelreichert previously approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@samuelreichert samuelreichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjulivan gjulivan force-pushed the rich-text-fixes branch 2 times, most recently from f74c907 to 5692909 Compare July 23, 2025 14:32
@gjulivan gjulivan enabled auto-merge (rebase) July 29, 2025 15:14
@gjulivan gjulivan merged commit ec0a8c6 into main Jul 29, 2025
14 checks passed
@gjulivan gjulivan deleted the rich-text-fixes branch July 29, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelreichert samuelreichert samuelreichert approved these changes

@leonardomendix leonardomendix leonardomendix approved these changes

Assignees
No one assigned
Labels
rich-text-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjulivan @samuelreichert @leonardomendix