[WC-3149][WC-3109]: tab keypress and softbreak on rich text #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
changed the title
gjulivan
force-pushed
the
rte-update
branch
3 times, most recently
from
e3be62e to
b67ccca
Compare
gjulivan
force-pushed
the
rte-update
branch
2 times, most recently
from
93d4856 to
c1a6401
Compare
samuelreichert
approved these changes
Dec 9, 2025
| import Quill from "quill"; | ||
| import Module from "quill/core/module"; | ||
| import QuillClipboard from "quill/modules/clipboard"; | ||
| // import QuillClipboard from "quill/modules/clipboard"; |
Contributor
There was a problem hiding this comment.
Suggested change
| // import QuillClipboard from "quill/modules/clipboard"; |
Maybe remove if the plan is to not use it anymore in the future
Comment on lines
+32
to
+67
| return [ | ||
| "address", | ||
| "article", | ||
| "blockquote", | ||
| "canvas", | ||
| "dd", | ||
| "div", | ||
| "dl", | ||
| "dt", | ||
| "fieldset", | ||
| "figcaption", | ||
| "figure", | ||
| "footer", | ||
| "form", | ||
| "h1", | ||
| "h2", | ||
| "h3", | ||
| "h4", | ||
| "h5", | ||
| "h6", | ||
| "header", | ||
| "iframe", | ||
| "li", | ||
| "main", | ||
| "nav", | ||
| "ol", | ||
| "output", | ||
| "p", | ||
| "pre", | ||
| "section", | ||
| "table", | ||
| "td", | ||
| "tr", | ||
| "ul", | ||
| "video" | ||
| ].includes(node.tagName.toLowerCase()); |
Contributor
There was a problem hiding this comment.
Should we have maybe a const here? like const TAG_NAMES = [...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description