Skip to content

Commit

Permalink
[Bug] different default values fixed (opensearch-project#1111)
Browse files Browse the repository at this point in the history 
* default values updated in bar chart

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* yarn test

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* unsed lines of code removed

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* yarn test

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
  • Loading branch information
@ramneet-persistent
ramneet-persistent authored Oct 12, 2022
1 parent 0f808ed commit dba5efe
Show file tree
Hide file tree
Showing 14 changed files with 87 additions and 94 deletions.
2 changes: 0 additions & 2 deletions common/constants/explorer.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -238,15 +238,13 @@ export interface DefaultBarChartStylesProps {
BarMode: string;
GroupWidth: number;
BarWidth: number;
LineWidth: number;
LabelSize: number;
}

export const DEFAULT_BAR_CHART_STYLES: DefaultBarChartStylesProps = {
BarMode: 'group',
GroupWidth: 0.7,
BarWidth: 0.97,
LineWidth: 1,
LabelSize: 12,
};

Expand Down
36 changes: 18 additions & 18 deletions public/components/custom_panels/helpers/__tests__/__snapshots__/utils.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -414,7 +414,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
"label": "Vertical bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "bar",
"orientation": "v",
Expand Down Expand Up @@ -809,7 +809,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -862,7 +862,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
"label": "Vertical bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "bar",
"orientation": "v",
Expand Down Expand Up @@ -1264,7 +1264,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -1317,7 +1317,7 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
"label": "Vertical bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "bar",
"orientation": "v",
Expand Down Expand Up @@ -3414,7 +3414,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -3467,7 +3467,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down Expand Up @@ -3862,7 +3862,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -3915,7 +3915,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down Expand Up @@ -4317,7 +4317,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -4370,7 +4370,7 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down Expand Up @@ -4796,7 +4796,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -4849,7 +4849,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down Expand Up @@ -5190,7 +5190,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -5243,7 +5243,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down Expand Up @@ -5591,7 +5591,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
},
Object {
"component": [Function],
"defaultState": 1,
"defaultState": 2,
"eleType": "slider",
"mapTo": "lineWidth",
"name": "Line width",
Expand Down Expand Up @@ -5644,7 +5644,7 @@ exports[`Utils helper functions renders displayVisualization function 4`] = `
"label": "Horizontal bar",
"labelangle": 0,
"legendposition": "v",
"linewidth": 1,
"linewidth": 2,
"mode": "group",
"name": "horizontal_bar",
"orientation": "h",
Expand Down
Loading

0 comments on commit dba5efe

Please sign in to comment.