Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Setup clang-format linting for Pull Requests #2

Closed
marv7000 opened this issue Jun 3, 2024 · 0 comments · Fixed by #3
Closed

[Feature] Setup clang-format linting for Pull Requests #2

marv7000 opened this issue Jun 3, 2024 · 0 comments · Fixed by #3
Assignees
@ByteOtter
Labels
enhancement New feature or request

Comments

@marv7000
Copy link
Contributor

marv7000 commented Jun 3, 2024

I feel it's important to keep the coding style concise. While this can be done moderately well by hand, IMO it's better if there is an automated sanity check.

Proposal

I'd like an automatic check that uses the .clang-format file to scan/lint (not sanitize, as there might be exceptions) all submitted files in a PR.
@marv7000 marv7000 added the enhancement New feature or request label Jun 3, 2024
@ByteOtter ByteOtter mentioned this issue Jun 3, 2024
Merged
marv7000 added a commit that referenced this issue Jun 3, 2024
@marv7000
Attempt #2
56f3ddc
marv7000 added a commit that referenced this issue Oct 9, 2024
@marv7000
my bad #2
8dd27b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ByteOtter ByteOtter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI/CD] Add clang-format workflow menix-os/menix
2 participants
@marv7000 @ByteOtter