Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request focuses on simplifying the RemoteModelConfig structure and removing unused fields and methods related to transformation requests and responses. The changes span multiple files, including model_config.h, remote_engine.cc, and remote_engine.h.

Simplification of RemoteModelConfig structure:

  • engine/config/model_config.h: Removed unused fields transform_req, transform_resp, metadata, and header_template from RemoteModelConfig. Updated the LoadFromJson, ToJson, and other related methods to reflect these removals. [1] [2] [3] [4] [5] [6] [7]

Removal of transformation request and response handling:

Update to ModelConfig struct:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review February 27, 2025 05:15
@vansangpfiev vansangpfiev changed the base branch from dev to main February 27, 2025 07:59
@vansangpfiev vansangpfiev merged commit 19f0c26 into main Feb 27, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/chore/remove-unused-fields-remote-model branch February 27, 2025 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants