Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request includes changes to the ModelSourceService and huggingface_utils files to improve error handling and streamline the process of skipping certain branches. The most important changes are listed below:

Error Handling Improvements:

  • engine/utils/huggingface_utils.h: Changed the return type of GetModelAuthorCortexsoHub from std::optional<std::string> to cpp::result<std::string, std::string> to better handle errors and provide more informative error messages.

Code Simplification:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev merged commit 24cf3e5 into main Feb 27, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/filter-out-main-branch-if-has-metadata branch February 27, 2025 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants