Skip to content

Commit

Permalink
Use partitionKey from context in FixedWindowDynamoDB
Browse files Browse the repository at this point in the history
  • Loading branch information
mennanov committed Dec 5, 2024
1 parent d0f9793 commit 1a725ff
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 1 deletion.
17 changes: 16 additions & 1 deletion fixedwindow.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,17 @@ func NewFixedWindowDynamoDB(client *dynamodb.Client, partitionKey string, props
}
}

type contextKey int

var fixedWindowDynamoDBPartitionKey contextKey

// NewFixedWindowDynamoDBContext creates a context for FixedWindowDynamoDB with a partition key.
//
// This context can be used to control the partition key per-request.
func NewFixedWindowDynamoDBContext(ctx context.Context, partitionKey string) context.Context {
return context.WithValue(ctx, fixedWindowDynamoDBPartitionKey, partitionKey)
}

const (
fixedWindowDynamoDBUpdateExpression = "SET #C = if_not_exists(#C, :def) + :inc, #TTL = :ttl"
dynamodbWindowCountKey = "Count"
Expand All @@ -212,9 +223,13 @@ func (f *FixedWindowDynamoDB) Increment(ctx context.Context, window time.Time, t
done := make(chan struct{})
go func() {
defer close(done)
partitionKey := f.partitionKey
if key, ok := ctx.Value(fixedWindowDynamoDBPartitionKey).(string); ok {
partitionKey = key
}
resp, err = f.client.UpdateItem(ctx, &dynamodb.UpdateItemInput{
Key: map[string]types.AttributeValue{
f.tableProps.PartitionKeyName: &types.AttributeValueMemberS{Value: f.partitionKey},
f.tableProps.PartitionKeyName: &types.AttributeValueMemberS{Value: partitionKey},
f.tableProps.SortKeyName: &types.AttributeValueMemberS{Value: strconv.FormatInt(window.UnixNano(), 10)},
},
UpdateExpression: aws.String(fixedWindowDynamoDBUpdateExpression),
Expand Down
17 changes: 17 additions & 0 deletions fixedwindow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,23 @@ func (s *LimitersTestSuite) TestFixedWindowOverflow() {
}
}

func (s *LimitersTestSuite) TestFixedWindowDynamoDBPartitionKey() {
clock := newFakeClockWithTime(time.Date(2019, 8, 30, 0, 0, 0, 0, time.UTC))
incrementor := l.NewFixedWindowDynamoDB(s.dynamodbClient, "partitionKey1", s.dynamoDBTableProps)
window := l.NewFixedWindow(2, time.Millisecond*100, incrementor, clock)

w, err := window.Limit(context.TODO())
s.Require().NoError(err)
s.Equal(time.Duration(0), w)
w, err = window.Limit(context.TODO())
s.Require().NoError(err)
s.Equal(time.Duration(0), w)
// The third call should fail for the "partitionKey1", but succeed for "partitionKey2".
w, err = window.Limit(l.NewFixedWindowDynamoDBContext(context.Background(), "partitionKey2"))
s.Require().NoError(err)
s.Equal(time.Duration(0), w)
}

func BenchmarkFixedWindows(b *testing.B) {
s := new(LimitersTestSuite)
s.SetT(&testing.T{})
Expand Down

0 comments on commit 1a725ff

Please sign in to comment.