Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace Coinbase delisted EUROC pairs #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nvtaveras
Copy link
Collaborator

Description

This replaces the delisted EUROCUSD pair on Coinbase with an implicit pairs that goes through EUROCUSDC instead.

Tested

Not yet tested. I’ll recommend doing the following for both EUROC/EUR and EUROC/XOF (as they were both updated):

  1. Run the price source configuration locally. I’d recommend doing two runs:
    1. First run using an existing price source that it’s currently working and doesn’t involve Coinbase’s EUROC/USD. Take note of the price reported
    2. A second run using only the price source configuration that involves the new Coinbase EUROC/USDC pair. The price reported should be very close to the previous run.
    3. A final run using all the price sources configuration from the helm charts in the PR.

Related issues

@nvtaveras nvtaveras changed the title fix: replace Coinbase delisted EUROCUSD with EUROCUSDC fix: replace Coinbase delisted EUROC pairs Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant