Feat(107): Participants section #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anna <anna.jezierska@neti-soft.com> Co-authored-by: denviljclarke <60730266+denviljclarke@users.noreply.github.com>
RyRy79261
requested review from
bowd and
nvtaveras
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...onents/create-proposal/create-proposal-wallet-step/create-proposal-wallet-step.component.tsx
Outdated
Show resolved
Hide resolved
src/components/proposal-current-votes/proposal-current-votes.component.tsx
Show resolved
Hide resolved
src/components/proposal-current-votes/proposal-current-votes.component.tsx
Outdated
Show resolved
Hide resolved
src/components/proposal-current-votes/proposal-current-votes.component.tsx
Outdated
Show resolved
Hide resolved
denviljclarke
suggested changes
Apr 22, 2024
nvtaveras
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM functionality wise, not a frontend expert so won't comment on the implementation details, although I noticed that there were some changes unrelated to the ticket which would be good to keep separate in in the future when possible.
Also curious if you tested it with a proposal with lots of votes in the different sections?
|
@nvtaveras So I tested with a 50/50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a scroll area component from Shadcn and fixes some styling inconsistencies
Review guide
It's tricky to test this out however in implementing I loaded a bunch of dummy elements into the participants section element
Related PR