Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(167): Vote lock align #168

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix(167): Vote lock align #168

merged 1 commit into from
Jun 7, 2024

Conversation

RyRy79261
Copy link
Contributor

Description

This PR fixes the lock on vote component

Testing

To test, create a proposal, then swap to a wallet that has no Mento or veMento

Related issues

@RyRy79261 RyRy79261 requested a review from a team June 6, 2024 11:23
@RyRy79261 RyRy79261 self-assigned this Jun 6, 2024
@RyRy79261 RyRy79261 requested review from nvtaveras and denviljclarke and removed request for a team June 6, 2024 11:23
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 11:23am

@RyRy79261 RyRy79261 changed the base branch from main to develop June 6, 2024 12:41
Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice once! It looks good to me. We should even go a step further and have a message for people who don't have MENTO. wdyt? The thinking is that what's the point of having them try to lock mento w/o any mento. It's fine for now though

Copy link
Contributor

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the preview

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chapati23 chapati23 merged commit 9c93d9d into develop Jun 7, 2024
2 checks passed
@chapati23 chapati23 deleted the fix/vote-lock-align-167 branch June 7, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Styling of cast votes component
4 participants