Feat/api mock #17
Merged
Feat/api mock #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AnnaJ-P11
reviewed
Jan 8, 2024
app/(routes)/page.tsx
Outdated
| @@ -26,10 +27,10 @@ const Page = () => { | |||
| Mento | |||
| </div> | |||
| <div className="hidden gap-x1 md:flex"> | |||
| <Button theme="clear" href="/create-proposal"> | |||
| <Button theme="clear" href="/create-proposal" disabled={!walletAddress}> | |||
There was a problem hiding this comment.
Tutaj wydaje mi się, że disabled nie będzie potrzebny, bo pierwszy step to Podłączenie do walleta gdyby nie był podłączony
| for: votesResponseJson.filter((vote: IVote) => vote.type === 'for'), | ||
| against: votesResponseJson.filter((vote: IVote) => vote.type === 'against'), | ||
| abstain: votesResponseJson.filter((vote: IVote) => vote.type === 'abstain'), | ||
| }; |
There was a problem hiding this comment.
Proponowałabym to dodać do wspólnej funkcji, ten kod powtzraz się w dwóch miejscach
const votesResponse = await fetch(/api/proposals/${id}/votes);
const votesResponseJson = await votesResponse.json();
const votes: ProposalVotesMap = {
for: votesResponseJson.filter((vote: IVote) => vote.type === 'for'),
against: votesResponseJson.filter((vote: IVote) => vote.type === 'against'),
abstain: votesResponseJson.filter((vote: IVote) => vote.type === 'abstain'),
};
AnnaJ-P11
approved these changes
Jan 9, 2024
tplocic20
force-pushed
the
feat/api-mock
branch
from
e164ec8 to
e8f8cbf
Compare
tplocic20
force-pushed
the
feat/api-mock
branch
from
e8f8cbf to
63ee2e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added zustand store and implemented it for all api calls