Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(165,169): Participants percentage & Current vote bar #170

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

RyRy79261
Copy link
Contributor

Description

This PR fixes the percentage calculation in the participant section as well as adds Abstain, to the voting indicator bars

Related issues

@RyRy79261 RyRy79261 requested a review from a team June 6, 2024 12:41
@RyRy79261 RyRy79261 self-assigned this Jun 6, 2024
@RyRy79261 RyRy79261 requested review from chapati23 and bowd and removed request for a team June 6, 2024 12:41
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 9:42am

@RyRy79261 RyRy79261 changed the title Fix(165): Participants percentage Fix(165,169): Participants percentage & Current vote bar Jun 6, 2024
@RyRy79261 RyRy79261 changed the base branch from main to develop June 6, 2024 12:44
Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue here, can't navigate to proposal details page i.e. https://governance-k1ebo4d11-mentolabs.vercel.app/proposals/76852543598626010309184355681141482743859825585547539168614458156040950326608

regardless of wallet connected/disconnected I always get console errors

image

@denviljclarke
Copy link
Contributor

Nice one. Left a comment about vote percentages. Looks good otherwise 👍

@bayological bayological dismissed chapati23’s stale review June 10, 2024 10:14

Reviewed by myself and Philip |

@RyRy79261 RyRy79261 merged commit 3762ffb into develop Jun 10, 2024
3 checks passed
@RyRy79261 RyRy79261 deleted the fix/participants-percentage-165 branch June 10, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants