Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup formatting with prettier #32

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Setup formatting with prettier #32

merged 9 commits into from
Jan 15, 2024

Conversation

bowd
Copy link
Contributor

@bowd bowd commented Jan 13, 2024

This PR does a couple of things:

  1. Installs prettier and configures it to run as an eslint rule and be enforced by eslint.
  2. Sets up a pre-commit hook using huskey to run lint before each commit. This requires a one time setup after installing the dependencies. Run npx husky install to activate the hooks.
  3. Sets up github actions workflow to run the linter in CI.
  4. Remove the .editorconfig.
  5. Lints all files for formatting.
  6. Fixes 3 code-related lining issues. See this commit: 9f71056

To review the PR I would recommend looking at the individual commits in isolation and ignore the two larger ones where linting is applied to the whole repo: 5c4f456 and 64fdfb6.

A note on (2): I quite like running it on pre-commit, but this can also be run on pre-push if the command gets too slow, but right now, it feels ok.

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 11:54am

@tplocic20 tplocic20 merged commit b77fc13 into main Jan 15, 2024
3 checks passed
@tplocic20 tplocic20 deleted the feat/setup-formatting branch January 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants