Proposal Details Page #54

chapati23 · 2024-02-09T16:53:38Z

Fixes #22

How to review

Check latest deployment
There should be a few proposals in different statuses
Go through acceptance criteria
Check code

Done

Extras

Fixed husky setup (never worked AFAICT) and added pre-commit and pre-push hooks
Added .prettierrc (otherwise it'd fallback to possible varying local editor configs)
Fixed eslint
Updated wagmi & viem
Added yarn todo script to parse out TODO comments

Resources

vercel · 2024-02-09T16:53:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
governance-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2024 0:16am

app/(routes)/proposals/[id]/page.tsx

there was a wagmi bug in useBlock that ignored the blockNumber argument which was recently fixed: wevm/wagmi@3f8203b

…ult configs

…maining TODOs

wagmi and viem types were misaligned after version updates, needed to update viem and PublicClient type usage

…cture

we guarantee it's at least an empty array in the proposal policy

- now using graphql fragments to share logic - added calldata to GetProposal query

introduction of fragments led to some issues with the auto-generated types for the GetProposal query types

better readability for numbers, adds thousand separators

also refactored voting start/end logic + some cleanup

…sary AFAIK useSuspenseQuery should guarantee data to always be defined

app/components/_shared/block-explorer-link/block-explorer-link.component.tsx

app/components/proposals-list/proposals-list.component.tsx

app/components/countdown/countdown.component.tsx

baroooo · 2024-02-16T17:10:09Z

I also noticed the countdown text is not visible on dark theme, caused by this line:

governance-ui/app/components/countdown/countdown.module.scss

Line 45 in 04a5ecf

color: #000;

chapati23 · 2024-02-19T11:26:12Z

I also noticed the countdown text is not visible on dark theme, caused by this line:

governance-ui/app/components/countdown/countdown.module.scss

Line 45 in 04a5ecf

color: #000;

nice catch, fixed

app/helpers/chains.ts

vercel bot had a problem deploying to Preview February 9, 2024 16:54 Failure

vercel bot deployed to Preview February 12, 2024 10:03 View deployment

vercel bot deployed to Preview February 12, 2024 17:24 View deployment

vercel bot deployed to Preview February 15, 2024 17:07 View deployment

vercel bot deployed to Preview February 16, 2024 09:57 View deployment

vercel bot deployed to Preview February 16, 2024 11:07 View deployment

vercel bot deployed to Preview February 16, 2024 11:41 View deployment

chapati23 marked this pull request as ready for review February 16, 2024 11:45

chapati23 changed the title ~~WIP: Proposal Details Page~~ Proposal Details Page Feb 16, 2024

tplocic20 approved these changes Feb 16, 2024

View reviewed changes

app/(routes)/proposals/[id]/page.tsx Show resolved Hide resolved

bowd and others added 19 commits February 16, 2024 12:50

feat: add single proposal query

9644174

chore: remove unused import

ee60332

feat(22): added startBlock and endBlock fields to getProposal schema

ad1ebcf

feat(22): updated wagmi to latest version to fix useBlock() bug

bb685d7

there was a wagmi bug in useBlock that ignored the blockNumber argument which was recently fixed: wevm/wagmi@3f8203b

chore: added basic .prettierrc to avoid conflicting local editor defa…

5187c72

…ult configs

chore: added 'npm run todo' script to print out all 'TODO' comments

a976e1b

chore(22): remove unnecessary typecast to any

302dfa5

feat(22): cleaned up proposal details, extracted components, noted re…

e9e7d55

…maining TODOs

chore(22): add todo comments

51e649a

fix(22): fixed typescript issue caused by wagmi update

c3595c4

wagmi and viem types were misaligned after version updates, needed to update viem and PublicClient type usage

chore: run 'npm run todo' in pre-commit hook to remind us of todos

c10b573

feat(22): wired up voting participants and refactored votes data stru…

c0e12cc

…cture

chore: fix broken husky setup

5521c77

chore(22): made VoteType.participants non-nullable graphql type

0724c51

we guarantee it's at least an empty array in the proposal policy

chore(22): refactored and extended proposal data

b92179d

- now using graphql fragments to share logic - added calldata to GetProposal query

chore(22): cleaned up proposal types

33441c7

introduction of fragments led to some issues with the auto-generated types for the GetProposal query types

feat(22): made total votes a locale string

9c72f4d

better readability for numbers, adds thousand separators

feat(22): implemented execution-code component

9d18a74

also refactored voting start/end logic + some cleanup

chore(22): updated graphql-codegen packages

f180437

chapati23 added 11 commits February 16, 2024 12:51

feat(22): created shared <BlockExplorerLink> component

6ec8079

feat(22): linked up more on-chain elements to block explorer

23bef3e

chore: small refactor & cleanup

1fb7523

chore(22): null check on data?.proposals should actually not be neces…

a567db7

…sary AFAIK useSuspenseQuery should guarantee data to always be defined

feat(22): only show "Cast Vote" box when proposal state is Active

15c23e6

chore(22): refactored getEndBlockTime helper

e4c457d

chore(22): remove outdated 'loading' logic

e3a6792

chore: removed 'yarn todo' from pre-commit hook to make DX faster

698b84f

chore: added pre-push hook to run lint and todo tasks

9b39fab

chore: also run build on pre-push to ensure we dont push broken code

7c0a046

fix(22): fixed countdown component

04a5ecf

chapati23 force-pushed the feat/proposal-details branch from c7750a0 to 04a5ecf Compare February 16, 2024 12:18

vercel bot deployed to Preview February 16, 2024 12:20 View deployment

baroooo reviewed Feb 16, 2024

View reviewed changes

app/components/_shared/block-explorer-link/block-explorer-link.component.tsx Show resolved Hide resolved

app/components/proposals-list/proposals-list.component.tsx Show resolved Hide resolved

app/components/countdown/countdown.component.tsx Show resolved Hide resolved

feat(22): set celoscan as default block explorer on alfajores

115539e

vercel bot deployed to Preview February 19, 2024 10:53 View deployment

chapati23 added 2 commits February 19, 2024 12:23

fix(22): fix invisible countdown in dark mode

47465dd

fix(22): fix invisible voting power in dark mode

30e1b5e

vercel bot deployed to Preview February 19, 2024 11:27 View deployment

chapati23 added 2 commits February 19, 2024 12:31

chore(22): removed unused helper function

c987af3

feat(22): only show countdown when voting is active

98c8499

vercel bot deployed to Preview February 19, 2024 11:34 View deployment

baroooo reviewed Feb 19, 2024

View reviewed changes

app/helpers/chains.ts Show resolved Hide resolved

feat(22): updated default block explorer on celo mainnet to celoscan

09de8be

vercel bot deployed to Preview February 19, 2024 12:16 View deployment

baroooo approved these changes Feb 19, 2024

View reviewed changes

chapati23 merged commit e34d520 into develop Feb 19, 2024
3 checks passed

chapati23 deleted the feat/proposal-details branch February 19, 2024 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposal Details Page #54

Proposal Details Page #54

chapati23 commented Feb 9, 2024 •

edited

Loading

vercel bot commented Feb 9, 2024 •

edited

Loading

baroooo commented Feb 16, 2024

chapati23 commented Feb 19, 2024

Proposal Details Page #54

Proposal Details Page #54

Conversation

chapati23 commented Feb 9, 2024 • edited Loading

How to review

Done

Extras

Resources

vercel bot commented Feb 9, 2024 • edited Loading

baroooo commented Feb 16, 2024

chapati23 commented Feb 19, 2024

chapati23 commented Feb 9, 2024 •

edited

Loading

vercel bot commented Feb 9, 2024 •

edited

Loading