-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: voting on proposals #69
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, voted for and against a proposal from different accounts and it all worked fine.
comments mainly on UX improvements and code structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we need to add frame
to the wallet options as we're getting an RPC error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app/components/vote-inactive-proposal-status-message/inactive-proposal-status-message.tsx
Outdated
Show resolved
Hide resolved
app/components/vote-inactive-proposal-status-message/inactive-proposal-status-message.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lfg
Description
This PR completes the voting component on the proposal page. It adds the functionality to:
I added a bit more information to the transaction in progress screen and an icon to the transaction submit success & transaction confirm states.
For reviewers: Ping me or @chapati23 for the pk to the dev wallet as it already has locked MENTO on alfajores which is needed to vote.
Other changes
Tested
Ran the locally and ensured voting was working and the voting component displayed the correct view based on the different states of the proposal and the users 'hasVoted' status
Related issues