Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-63 proposals design fixes #78

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Conversation

AnnaJ-P11
Copy link
Contributor

@AnnaJ-P11 AnnaJ-P11 commented Mar 14, 2024

Description

  • the entire component was checked and changes were made in line with the designs
  • fixed progressbar styling when the value is minimal
  • fix progressbar styling
  • Remove proposals IDs
  • Change fonts in whole proposals list
  • change statuses to be written in black

Other changes

  • add Inter font

Tested

Go to porposals list

Related issues

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 0:04am

app/globals.scss Outdated Show resolved Hide resolved
@tplocic20 tplocic20 self-requested a review March 14, 2024 14:07
@denviljclarke
Copy link
Contributor

Nice @AnnaJ-P11. I left a few comments. I also made a commit adding inter using Next.js. I think it's good to use it from there since we already have it installed.

Also, I see in the designs that there is supposed to be pagination this component, do you know why it's not implemented?

Link to pagination in the design

@AnnaJ-P11
Copy link
Contributor Author

Nice @AnnaJ-P11. I left a few comments. I also made a commit adding inter using Next.js. I think it's good to use it from there since we already have it installed.

Also, I see in the designs that there is supposed to be pagination this component, do you know why it's not implemented?

Link to pagination in the design

Ok, thanks. It looks like pagination has recently been added to the design. I haven't seen it before

Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some code which I introduced in error when testing how a shorter proposal list would look.

Apart from that note - LGTM 👍

@AnnaJ-P11 AnnaJ-P11 merged commit 22bad62 into develop Mar 21, 2024
3 checks passed
@AnnaJ-P11 AnnaJ-P11 deleted the fix/63-proposals-design-fixes branch March 21, 2024 08:28
RyRy79261 pushed a commit that referenced this pull request Mar 21, 2024
Co-authored-by: denviljclarke <60730266+denviljclarke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants