Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bread crumb colors and missing proposal id #85

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix: bread crumb colors and missing proposal id #85

merged 3 commits into from
Mar 21, 2024

Conversation

nvtaveras
Copy link
Contributor

Description

Small fix on the breadcrumb component to:

  1. fix the colors on the individual crumbs, as they were inverted from the figma design
  2. add a short version of the proposal id when the user navigates to a specific proposal page

Tested

Ran it locally

Related issues

@nvtaveras nvtaveras changed the base branch from main to develop March 18, 2024 16:52
@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 2:01pm

@nvtaveras nvtaveras requested review from a team, baroooo, philbow61 and denviljclarke and removed request for a team and baroooo March 18, 2024 17:11
denviljclarke
denviljclarke approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@denviljclarke denviljclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌.
LG, it works as it should. I left a few comments; you can decide if making the changes is worth it.

@tplocic20 tplocic20 self-requested a review March 19, 2024 10:25
@nvtaveras nvtaveras merged commit 5221b0d into develop Mar 21, 2024
3 checks passed
@nvtaveras nvtaveras deleted the fix/breadCrumbNav branch March 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 left review comments

@denviljclarke denviljclarke denviljclarke approved these changes

@tplocic20 tplocic20 tplocic20 approved these changes

@philbow61 philbow61 Awaiting requested review from philbow61 philbow61 was automatically assigned from mento-protocol/core-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the breadcrumbs component
4 participants
@nvtaveras @tplocic20 @RyRy79261 @denviljclarke