Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Slither Warnings on GoodDollar & Bancor Contracts #525

Closed
3 tasks
chapati23 opened this issue Oct 11, 2024 · 0 comments
Closed
3 tasks

Resolve Slither Warnings on GoodDollar & Bancor Contracts #525

chapati23 opened this issue Oct 11, 2024 · 0 comments
Assignees
@chapati23

Comments

@chapati23
Copy link
Contributor

There are a number of slither warnings on the GoodDollar & Bancor contracts that need to be analyzed and resolved.

What

  • Run slither (yarn slither)
  • Resolve all issues (either by code change for legitimate warnings or adding inline ignore comments to silence them, along with an explanation on why we're silencing them)
  • Make sure CI is green (incl. slither job)
@chapati23 chapati23 self-assigned this Oct 11, 2024
@chapati23 chapati23 mentioned this issue Oct 11, 2024
Merged
chapati23 added a commit that referenced this issue Oct 15, 2024
@chapati23
Address Slither Issues in GoodDollar/Bancor Contracts (#526)
914ba7d 
### Description

Fixes #525

Mostly false positives where I added comments.

One change I did make was adding reentrancy guards to the `mint`
functions in the `GoodDollarExpansionController`.

Even though the slither warnings were only a "medium" around possibly
manipulating event data via re-entrancy, I thought it'd still be a good
idea to disallow reentrancy for all mint functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chapati23 chapati23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chapati23