Streamline comments and errors #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setExitContribution, createExchange, destroyExchange are now onlyAvatar instead of onlyOwner for the GoodDollarExchangeProvider
they didn't add any value as the mint functions only interact with trusted contracts and tokens
using @inheritdoc for 0.8 contracts to reduce duplicate comments
chapati23
force-pushed
the
chore/streamline-comments-and-errors
branch
from
d962735 to
03b2275
Compare
baroooo
approved these changes
Oct 18, 2024
| @@ -9,6 +9,7 @@ interface IGoodDollar { | |||
|
|
|||
| function safeTransferFrom(address from, address to, uint256 value) external; | |||
|
|
|||
| // Only used in Fork Tests to give the Broker minting rights during testing | |||
There was a problem hiding this comment.
not sure if this comment makes sense since it is specific to how we use the interface
There was a problem hiding this comment.
yeah, agreed, was just a stream-of-thought comment for me I think, removed
chapati23
commented
Oct 18, 2024
bowd
pushed a commit
that referenced
this pull request
Oct 24, 2024
7704a9b chore: reserve storage gap in new contracts 040b7fe GoodDollar Fork Tests (#530) 2ee14b4 Feat(454): Exchange provider tests (#529) 578747c test: add BancorExchangeProvider pricing tests (#532) fcd3d02 feat: improve tests around the expansion controller (#533) d3a31fa Streamline comments and errors (#528) ec64f0a fix: ☦ pray to the lords of echidna 13d3a98 fix: add back forge install to the CI step c236009 fix: echidna tests c50a198 feat: add Broker liquidity check (#523) 914ba7d Address Slither Issues in GoodDollar/Bancor Contracts (#526) 8bcf3fd Feat/change gdollar modifiers (#524) 379a511 feat: make validate() internal bcbd9aa chore: added "yarn todo" task to log out open todos in the code 0631c60 refactor: renamed SafeERC20 to SafeERC20MintableBurnable 2800297 feat: simplified SafeERC20 e858391 feat: extend open zeppelin's IERC20 instead of duplicating it 196f6be chore: fixed linter and compiler warnings 096efe2 test: fix fork integration test e5308d9 feat: add GoodDollar contracts + tests 3135626 feat: update Broker + TradingLimits to 0.8 and make G$ changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/mento-protocol/mento-general/issues/552
Broker.configureTradingLimit()frompublicto external