-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add BancorExchangeProvider pricing tests #532
Merged
philbow61
merged 8 commits into
feat/GDollar-of-latest-develop
from
test/BancorExchangeProvider
Oct 23, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c389250
test: add BancorExchangeProvider pricing tests
philbow61 d45a22e
chore: merge latest base branch
philbow61 27d3656
Revert "chore: merge latest base branch"
philbow61 8f8a753
Merge branch 'feat/GDollar-of-latest-develop' into test/BancorExchang…
philbow61 5022124
feat: update revert for 0 reward
RyRy79261 c30d05d
Apply suggestions from code review
philbow61 05c82e5
chore: incorperate review feedback
philbow61 0eed560
fix: reverted stray commit
RyRy79261 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entrenched in context enough to assess the potential implications for this implementation.
But at the minimum, the setting of
baseD
,temp1
&temp2
as variables in this function can be removed to improve gas efficiency.