-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: locking l2 upgrade #542
Conversation
I think the ci is failing because they removed regex parsing for version pragma in a recent foundry upgrade which is causing similar problems for other people. It also fails for dev branch at the moment. It should be fixed once this change is released: edit: they are fast :D the fix is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work on testing this.
1 thing can we add a test in the fork tests verifying pausing the locking contract results in
in Governance operations are being blocked:
- propose
- voting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🙏 😍 - have only cosmetic comments, and more meant as a discussion, so let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, way more readable now!
Description
Updates Locking Contracts to handle upcoming block.time change
Mainly changes the roundTimestamp() to have a forked implementation that uses different values to calculate week no for the blocks before and after l2 transition. Week numbers that return from roundTimestamp before and after should be continues and consistent.
Other changes
No
Tested
Unit and fork tests
Related issues