Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locking upgrade fork test #574

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

baroooo
Copy link
Contributor

@baroooo baroooo commented Jan 22, 2025

Description

Locking Upgrade fork tests were failing because:

  1. Locking proxy admin is owned by the multisig now
  2. A subtle issue in how we handle timetraveling causing problems with brokenLine internals because we fork the current block's state, roll back to Nov 7 roll forward 3 weeks and make calculations for the month December. Which causes brokenLine.update to try updating the line for a past time if you run the test after December. (kudos to @philbow61)

This PR fixes the tests by setting up the fork test correctly and moving 30 weeks into future before starting tests

Other changes

_calculateBlocksTillNextWeek uses values from the contract now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants